[Bug 41417] Support Facebook's own-message extension

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=41417

Will Thompson <will.thompson at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |http://cgit.collabora.com/g
                   |                            |it/user/wjt/telepathy-gabbl
                   |                            |e-wjt.git/log/?h=facebook-o
                   |                            |wn-message
           Keywords|                            |patch

--- Comment #2 from Will Thompson <will.thompson at collabora.co.uk> 2011-11-04 09:47:57 PDT ---
It's finished! The delivery reports use Delivery_Status_Accepted: all we know
is that the message reached the Facebook server. They don't have delivery-token
because Facebook doesn't give us the id='' of the message we sent. Sigh.
Whether the message was sent locally or via some other client is not exposed;
should I invent a key for that, do people think? I think we can revisit that
when some UI exposes this.

The actual Facebook patch is quite small. The branch, on the other hand, is
quite big. But it's mostly bits of cleanup plus a bit of refactoring of the
delivery report code. So it shouldn't be too heavy to review.

There's a slight quirk in this which I discovered while testing it: if I send
Jonny a message using the email-style interface in the Facebook web interface,
I (sometimes, but not always) get an own-message push, but the to='' attribute
on own-message is wrong: it claims that I sent the IM to myself! So Gabble
doesn't push it out as a delivery report, because I don't have an IM channel
open to myself. (Gabble can't actually (easily) detect that this has happened:
it thinks my JID is will.joseph.thompson at chat.facebook.com/..., but the to=''
attribute on own-message  is -36800444 at chat.facebook.com.)

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.