[Bug 42348] Review Chan.I.FileTransfer.Metadata

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=42348

--- Comment #1 from Will Thompson <will.thompson at collabora.co.uk> 2011-11-09 09:05:48 PST ---
In add_metadata_forms:

+      else
+        {
+          list = g_list_append (list, form);
+        }

Is this in the Gabble branch too? Use a GQueue. I guess I got distracted by the
yucky tree building.

The rest looks very familiar. I guess some of my review comments from the
Gabble bug may also apply here?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.