[Bug 42508] Support for building on Android

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=42508

--- Comment #5 from Will Thompson <will.thompson at collabora.co.uk> 2011-11-10 07:27:02 PST ---
Comment on attachment 53044
  --> https://bugs.freedesktop.org/attachment.cgi?id=53044
Suppport for Android

Review of attachment 53044:
 --> (https://bugs.freedesktop.org/page.cgi?id=splinter.html&bug=42508&attachment=53044)
-----------------------------------------------------------------

::: Android.mk
@@ +4,5 @@
> +
> +TELEPATHY_MISSION_CONTROL_BUILT_SOURCES := \
> +	mission-control.pc \
> +	src/Android.mk \
> +	libmcclient/Android.mk \

libmcclient has been removed; so this patch will need updating.

@@ +35,5 @@
> +
> +#include all the subdirs...
> +-include $(TELEPATHY_MISSION_CONTROL_TOP)/src/Android.mk
> +-include $(TELEPATHY_MISSION_CONTROL_TOP)/util/Android.mk
> +-include $(TELEPATHY_MISSION_CONTROL_TOP)/libmcclient/Android.mk

Ditto

::: server/Makefile.am
@@ +49,5 @@
> +	  -DBUILD_AS_ANDROID_SERVICE \
> +	 -:LDFLAGS $(mission_control_5_LDADD) -ldbus-1 -ldbus-glib-1 \
> +	  -lmcclient \
> +	 -:LIBFILTER_STATIC missioncontrol-server mission-control-plugins \
> +	  mcclient \

ditto

::: server/mc-server.c
@@ +34,5 @@
>  static TpDebugSender *debug_sender;
>  
> +#ifdef BUILD_AS_ANDROID_SERVICE
> +int telepathy_mission_control_main (int argc, char **argv);
> +#endif

Doesn't having a non-static prototype in a .c file trigger a warning from the
compiler?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.