[Bug 42814] Migrate Butterfly accounts

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=42814

--- Comment #3 from Guillaume Desmottes <guillaume.desmottes at collabora.co.uk> 2011-11-14 05:17:09 PST ---
(In reply to comment #2)
> (In reply to comment #1)
> > Here we go
> > http://cgit.collabora.com/git/user/cassidy/telepathy-mission-control/log/?h=butterfly-migration-42814
> 
>      release_load_accounts_lock (lad);
> +
> +    migrate_accounts (account_manager);
> 
> I think you want to take an account lock for each account being migrated, and
> release each one when the migration succeeds or fails; and call
> migrate_accounts() before this call to release_load_accounts_lock().
> 
> account_lock is used to stop the account manager appearing on the bus until all
> the accounts are loaded up and ready to go. Presumably we want the migration to
> happen before MC appears on the bus? (With this branch at present, that's not
> the case.)

Good point. I've done that in a new patch.

> It would be nice to annotate the new accounts with some indicator of the
> account path they replace.

We should either add a Account.Replace (as) or Account.Misc a{sv} property to
do so.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.