[Bug 32691] Support addressing in TpBaseProtocol

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=32691

--- Comment #6 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2011-11-14 05:20:34 PST ---
The implementation looks fine; some naming/documentation/g-i issues.

+/**
+ * TpBaseProtocolGetSupportedVCardFields:

Needs a Returns: line. Did you build this branch with gtk-doc? Did it tell you
you were missing this?

The Returns: line gives you a chance to say "a list of vCard fields in lower
case, e.g. [x-sip, tel]" or whatever - SIP makes a great example for this sort
of thing, because it typically supports both SIP and telephony, and its vCard
field and URI scheme don't have the same name.

It's actually Returns: (allow-none) (out) (transfer full): ... in order to have
the g-i annotations right, I think.

Neither you nor Eitan fixed this:

> > + * TpBaseProtocolGetAddressingDetailsFunc:
>
> ...Dup... rather than Get, really.

Also, I think a typedef for a function pointer should generally say ...Func at
the end (this one did in Eitan's initial branch, not sure what happened to
that).

+/**
+ * TpBaseProtocolGetSupportedURISchemes:

All comments about SupportedVCardFields apply here. Again, consider using SIP
as your example, to have [sip, sips, tel].

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.