[Bug 41897] Generate code for Call1

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=41897

Xavier Claessens <xclaesse at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|http://cgit.collabora.com/g |http://cgit.collabora.com/g
                   |it/user/wjt/telepathy-glib. |it/user/xclaesse/telepathy-
                   |git/log/?h=call1            |glib.git/log/?h=call1

--- Comment #3 from Xavier Claessens <xclaesse at gmail.com> 2011-11-21 11:22:36 PST ---
Latest call1 code is available here:
http://cgit.collabora.com/git/user/xclaesse/telepathy-glib.git/log/?h=call1

It contains generated code for call1 spec, complete client-side high-level API
(TpCallChannel, TpCallContent and TpCallStream) and WIP service-side high-level
API (TpBaseCallChannel, TpBaseCallContent and TpBaseCallStream).

TODO/open questions:
 * missing gtkdoc for TpBaseCall*
 * tp_base_call_channel_set_state() should set flags and details? Some flags
like RINGING can be handled internally, but not all afaik.
 * tp_base_call_channel_update_member_flags() should emit StateChanged
 * TpBaseCallStreamRequestReceivingFunc should return gboolean for success
 * tp_base_call_*: add g_return_if guards
 * add padding to public class structs for future vtable
 * SetQueued no implemented
 * Why tp_base_call_channel_set_ringing_dbus() does not call a vmethod to let
protocol inform the other side?
 * why is TpBaseCallContent the only object to have a deinit?
 * why does TpBaseCallContent and TpBaseCallStream register themself on the
bus? other TpBase let subclass decide
 * Shouldn't tp_base_call_channel_hangup() remove all contents for us? or
assert they are all removed after vmethod?
 * When removing a content, do we have to remove its streams before? should we
assert that the content has no stream when removing it?
 * When hangup the call, should we remove members?
 * Should tp_base_call_channel_add_content_dbus() assert that vmethod called
tp_base_call_channel_add_content()?
 * Why is initial_audio in public TpBaseCallChannel struct but not
initial_audio_name?
 * TpyBaseCallChannel implements the DTMF iface, but does all protocal wants
it? How are CMs supposed to implement DTMF, I see no way for TpyBaseCallChannel
subclasses to access priv->dtmf_player...
 * Does mutable-contents==FALSE means we can't add and can't remove contents?
is it possible to have protocols that can add but not remove or the other way
around? Is it possible that a protocol can add or remove audio content but not
video content?
 * Content::remove(): spec says Google Talk video call can't remove content and
should raise Not Implemented (shouldn't it be NotCapable?) but
TpyBaseCallContent does not let subclass define if it is supported. Should it
just check the mutable-contents property?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.