[Bug 43222] Add Qt5 support

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=43222

--- Comment #4 from Olli Salli <ollisal at gmail.com> 2011-11-24 12:10:12 PST ---
+ * method will always fail unless QHostAddress::Any (also
QHostAddress::AnyIPv4 if using Qt5) or

"or AnyIPv4 in Qt5"

> QtDBus >= ${QT_MAX_VERSION}, QtDBus < ${QT_MIN_VERSION}

Doesn't look like that would be satisfiable very easily :)

(In reply to comment #2)
> Summary of current faults from private correspondence:
> 
> * The user must be able to choose whether to build a qt4 or qt5 lib even if
> pkgconfig finds both, as it will in real world systems where qt4 and qt5 will
> co-exist for a long time

Actually already possible with DESIRED_QT_VERSION, the mechanism just needs to
be careful to not accidentally pick up Qt5 although one tried selecting qt4 and
vice versa. So double check both directions before merge please...

> 
> * The built library must be named such that versions built for qt4 and qt5 can
> be parallel installed

Done now! Also extends to pkgconfig and even headers after some discussion. So
we're going to have full parallel installability of also -dev packages.

> 
> * We must have a summary of backwards incompat changes in NEWS to enable people
> to know how to port

To be done per-branch when merging, as the branch is now thankfully split as
per the different kinds of changes.

> 
> * Conditional compilation to pass the right constants to attain the API's
> *default behavior* should not be required of the API's user (despite semantics
> change in QHostAddress::Any between qt4 and qt5). We must abstract away such
> things.

Andre's currently working on this. We hit a Qt5 bug in the process... fun
times.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.