[Bug 43222] Add Qt5 support

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=43222

--- Comment #8 from Olli Salli <ollisal at gmail.com> 2011-11-25 03:22:30 PST ---
(In reply to comment #6)
> (In reply to comment #3)
> >     explicit inline SharedPtr(const QWeakPointer<T> &o)
> >     {
> >         if (o.data() && o.data()->strongref.fetchAndAddOrdered(0) > 0) {
> >             d = static_cast<T*>(o.data());
> >             d->ref();
> >         }
> > 
> > Used like that, the atomic integer is completely useless. First after the
> > o.data() check, an another thread can cause it to go NULL, and then after the
> > refcount check, an another thread can cause it to drop to zero and the object
> > be deleted.
> This is true, could you please file a bug for that with the rationale above. In
> the meantime I will leave this branch using fetchAndAddOrdered, so it works
> with both qt4 and qt5
> 

Done now, as bug 43239. That is a blocker for finishing the tp-qt >= 0.9 ABI
break. Put a big note (mental or comment) somewhere that this needs to be
fixed, because actually otherwise SharedPtr *does not* in fact work fully in
its purpose in either qt4 or qt5, although yes the code compiles.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.