[Bug 40518] Contacts appear in local pending and then immediately disappear again on GTalk

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=40518

--- Comment #2 from Will Thompson <will.thompson at collabora.co.uk> 2011-09-07 03:47:32 PDT ---
+    # We add Alice
+    presence = domish.Element(('jabber:client', 'presence'))
+    presence['from'] = contact
+    presence['type'] = 'subscribe'
+    stream.send(presence)

This comment is wrong. What's happening here is that Alice is trying to
subscribe to *us*.

I think it's worth explicitly saying in either the code comment or the test
that Google's not striiiictly speaking buggy:subscription='none' on the roster
item is not technically a change if they weren't on the roster before, it just
means that they're now explicitly on the roster with subscription='none', as
opposed to not on the roster (implicitly with subscription='none').

+    When somebody asks to subscribe to us, Google sends the subscription
+    request and then a roster update saying there is no subscription.

So here, for instance: the roster update doesn't technically contradict the
request.

We should test that receiving <presence type='unsubscribe'/> followed by a
roster push like the one Google sends is correctly treated as notification that
Alice has cancelled her subscription request:
http://xmpp.org/rfcs/rfc6121.html#sub-cancel-inbound

It may already be tested, but I'm tempted to say it should be tested in this
test case, too, to guarantee that ignoring the roster push doesn't have
knock-on effects.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.