[Bug 38248] Get handle identifiers for contacts related to a channel

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=38248

--- Comment #22 from Guillaume Desmottes <guillaume.desmottes at collabora.co.uk> 2011-09-29 06:55:09 PDT ---
http://cgit.collabora.com/git/user/xclaesse/telepathy-glib.git/commit/?h=channel-contacts&id=2a5d07781b72e19d89e6601036650149a933705b

Not mergeable. We should do a spec release and sync tp-glib.


tp_svc_channel_interface_group_emit_handle_owners_changed_detailed (
    obj, empty_hash_table, arr_owners_removed, empty_hash_table);
According to the spec we MAY include the identifier of the removed handles;
any reason to not to?

dup_handle_array(): can't we use g_array_ref? Doesn't dbus-glib play nice with
GArray now?

dup_owners_table(): you don't check if dup_contact returned NULL.

contacts_queue_item_set_contacts(): add a "g_assert (item->contacts == NULL);"
to make sure we don't leak contacts?

tp_channel_group_get_contact_owner:
* - if @self does not have flags that include
 *   %TP_CHANNEL_GROUP_FLAG_PROPERTIES,
 *   result is undefined;
Did you mean TP_CHANNEL_GROUP_FLAG_CHANNEL_SPECIFIC_HANDLES?

_tp_channel_contacts_prepare_async
          "The Connection Manager does not implement the required telepathy "
          "specification to prepare TP_CHANNEL_FEATURE_CONTACTS");
Include the spec version number?

+   * TpChannel::group-contacts-changed:
+   * @added: (type GLib.PtrArray) (element-type TelepathyGLib.Contact):
+   *  a #GList of #TpContact containing the full members added
It's not a GList.
ditto for the other args.
Say that those contacts have been prepared if possible?


http://cgit.collabora.com/git/user/xclaesse/telepathy-glib.git/commit/?h=channel-contacts&id=bad617f34e09084ef977fa11fa2f1ae1af5cffbe

+  g_print ("contact added: %s\n", tp_contact_get_identifier (g_ptr_array_index
(added, 0)));
should be removed.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.