[Bug 48544] New: replace bitfields with flags or separate booleans as appropriate

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=48544

             Bug #: 48544
           Summary: replace bitfields with flags or separate booleans as
                    appropriate
    Classification: Unclassified
           Product: Telepathy
           Version: git master
          Platform: Other
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: tp-glib
        AssignedTo: telepathy-bugs at lists.freedesktop.org
        ReportedBy: simon.mcvittie at collabora.co.uk
         QAContact: telepathy-bugs at lists.freedesktop.org


This:

> > +  unsigned had_weak_object:1;

is pretty ugly.

Where booleans make most sense, we should use "gboolean had_weak_object;" and
just accept the extra memory. We don't necessarily even need to wait for next;
we can do this in master.

I suspect that in at least some cases we'd be better off with an explicit flags
word, though:

    http://blog.ometer.com/2011/01/20/boolean-parameters-are-wrong/

(in which case we might be changing the API; if so, that's a reason to make the
change in next).

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.