[Bug 30338] TpRoomList - High level API for RoomList channel

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=30338

--- Comment #6 from Jonny Lamb <jonny.lamb at collabora.co.uk> 2012-04-13 15:50:53 PDT ---
(In reply to comment #5)
> http://cgit.collabora.com/git/user/cassidy/telepathy-glib/log/?h=tp-room-list-30338

A loooot of new code late on a Friday makes me think I might've missed
something but it seems to look fine from here...

> a) I didn't include any API to stop the listing. What about calling
> StopListing() automatically when the proxy is invalidated? The requester should
> close the channel anyway once it's done with it.

That seems reasonable to me.

> b) Should start_listing_async() be renamed to list_async() or something,
> complete when the list operation is done (ListingRooms goes back to FALSE) and
> return the  list of TpRoomInfo found. User will still have the got-rooms signal
> to display rooms while they are found, but having a list API to returning any
> result looks a bit weird to me.

Good point. I would also be fine if you did this list_async() rename.

Any further preferences, Simon?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.