[Bug 48780] add API to request channels without speaking fluent D-Bus

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=48780

--- Comment #16 from Jonny Lamb <jonny.lamb at collabora.co.uk> 2012-04-17 10:35:22 PDT ---
Comment on attachment 60079
  --> https://bugs.freedesktop.org/attachment.cgi?id=60079
02/14] tp_account_channel_request_new_text,                
tp_account_channel_request_set_target_contact, 
tp_account_channel_request_set_target_id: add

Review of attachment 60079:
 --> (https://bugs.freedesktop.org/page.cgi?id=splinter.html&bug=48780&attachment=60079)
-----------------------------------------------------------------

::: telepathy-glib/account-channel-request.c
@@ +1820,5 @@
> +  g_return_val_if_fail (TP_IS_ACCOUNT (account), NULL);
> +
> +  request = tp_asv_new (
> +      TP_PROP_CHANNEL_CHANNEL_TYPE, G_TYPE_STRING, TP_IFACE_CHANNEL_TYPE_TEXT,
> +      NULL);

Didn't you just say you shouldn't use tp_asv_new here? This just gets duped and
the value freed with g_free() no? Am I missing something here?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.