[Bug 39248] [API break] Use GQuark for TpContact features, or opaque pointers for all features

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=39248

--- Comment #6 from Jonny Lamb <jonny.lamb at collabora.co.uk> 2012-04-18 02:16:27 PDT ---
(In reply to comment #5)
> > I'm pushing the proxy feature stuff into a mixin so hopefully
> > TpContact can use it after some modifications.
> 
> I'm unsure about this. Proxy features are very much "you prepare the object",
> whereas contact features are "you prepare a batch" (and have pessimal
> performance if you don't). I'm not sure that they're really enough of "the same
> shape" to merge the implementations.
> 
> (There's a little bit of crossover, in that the account manager prepares
> multiple accounts - but you have nowhere near as many accounts as contacts, and
> our D-Bus API can't batch account preparation anyway.)
> 
> My inclination would be to make the APIs consistent, and worry about the
> implementation later, if at all?

Hmm, yeah I guess you're right here, unfortunately.

Shall we still include this TpFeatureMixin like I've done even if we don't use
it for TpContact? It might be useful if for nothing else but splitting up code
to make it more legible and more split-up?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.