[Bug 39248] [API break] Use GQuark for TpContact features, or opaque pointers for all features

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=39248

--- Comment #9 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2012-04-20 08:43:23 PDT ---
(In reply to comment #8)
> Okay here's the branch you always wanted to see.

Looks good, except that if you give random undefined quarks to a function
expecting contact features, I'd like to see that be a critical (like it is for
TpProxy) rather than silently accepted.

Rationale: it's far too easy to miss off the 0-termination...

(In reply to comment #3)
> (Or, for that matter, change those three to use the (n, array) pattern. Your
> call!)

... which is also an argument for changing everything to do this instead of the
zero-termination pattern; but let's merge your branch first so it's at least
consistent, then decide whether to be consistently the other thing afterwards.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.