[Bug 30338] TpRoomList - High level API for RoomList channel

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=30338

--- Comment #15 from Xavier Claessens <xclaesse at gmail.com> 2012-04-25 04:38:05 PDT ---
TpRoomInfo:

 - SECTION doc refers to TpRoomListChannel which does not exist

 - I know this is common, but GObjectClass guarantees that finalize/dispose/etc
are non-NULL, they implement them explicitly to not having to check in every
subclass.
+  void (*chain_up) (GObject *) =
+      ((GObjectClass *) tp_room_info_parent_class)->finalize;

 - tp_room_info_get_members() I was surprised it return a number, I was
expecting getting a list of TpContact from the func name... maybe
_get_n_members()? or _get_members_count()?

 - Shouldn't it expose each getter as a property as well?

 - I'm not fan of self->priv->hash name, it does not tell what it contains.
'asv' would already describe it better... or "parameters" maybe?



TpRoomList:

 - SECTION doc says it's a TpChannel subclass... it's not.

 - "got-rooms" signal emits only one room at a time, right? so no plurial
needed.

 - tp_room_list_get_listing() --> _is_listing() ?

 - I think it should "keep its state". I mean that if you miss signals, you
can't know the rooms listed, or the fail error... I would like a getter for
those 2.




simple-conn.c:

 - chan = g_hash_table_lookup (self->priv->channels, GUINT_TO_POINTER (0));
WTF using 0 as key?? is that really on purpose?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.