[Bug 48230] [next] tp_am_set_default() should keep a weak ref instead of strong ref

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=48230

--- Comment #2 from Jonny Lamb <jonny.lamb at collabora.co.uk> 2012-04-25 07:56:31 PDT ---
Comment on attachment 60571
  --> https://bugs.freedesktop.org/attachment.cgi?id=60571
tp_am_set_default(): Take a weak ref instead of a strong one

Review of attachment 60571:
 --> (https://bugs.freedesktop.org/page.cgi?id=splinter.html&bug=48230&attachment=60571)
-----------------------------------------------------------------

Looks good, but I've slightly re-worded your doc.

::: telepathy-glib/account-manager.c
@@ +786,5 @@
>   * tp_account_manager_new_with_factory().
>   *
> + * Only a weak reference is taken on @manager, it is caller's responsability to
> + * keep it alive. Otherwise next call to tp_account_manager_dup() will return
> + * a newly created #TpAccountManager.

Only a weak reference is taken on @manager. It is the caller's responsibility
to keep it alive. If @manager is disposed after calling this function, the next
call to tp_account_manager_dup() will return a newly created #TpAccountManager.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.