[Bug 46835] [next] disentangle circular dependencies and move tp_cli_* into -dbus library

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Mon Apr 30 17:22:22 CEST 2012


https://bugs.freedesktop.org/show_bug.cgi?id=46835

--- Comment #31 from Jonny Lamb <jonny.lamb at collabora.co.uk> 2012-04-30 08:22:22 PDT ---
(In reply to comment #30)
> (In reply to comment #27)
> > > +tp_proxy_dbus_g_proxy_claim_for_signal_adding (DBusGProxy *proxy)
> > 
> > OOI, why has this been moved to core-proxy?
> 
> Generated code calls it (tp_cli_connection_add_signals and similar), and we
> want that generated code to go in the -dbus library.

Ah yes I see. Fair enough.

> I could do the same semi-inlining trick, but this entire function is
> "core-able" (it just pokes at the DBusGProxy's qdata, with no real TpProxy
> involvement) so there seemed no point.

Yeah, don't bother.

> (In reply to comment #29)
> > It's funny, this all looks quite simple now you've reached a solution but when
> > I was playing with it a while ago it wasn't very clear or simple at all!
> 
> Don't feel bad about that, it took me days/weeks of trying wrong solutions
> before I realised this one was viable :-)

Yeah, nice work!

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.



More information about the telepathy-bugs mailing list