[Bug 43828] avoid downloading the roster at every connection

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=43828

--- Comment #2 from Alban Crequy <alban.crequy at collabora.co.uk> 2012-01-04 08:21:42 PST ---
Thanks for the review.

(In reply to comment #1)
> Here goes a first review, but I would prefer if some gabble developer could
> check it also.
> 
> The spec states that when DownloadAtConnection is true, Download should do
> nothing, so no need to raise an error if the roster was already requested.

Fixed.

> + gabble_simple_async_succeed_or_fail_in_idle (self, callback, user_data,
> + gabble_roster_request_subscription_async, error);
> 
> I guess this should be:
> gabble_simple_async_succeed_or_fail_in_idle (self, callback, user_data,
>     gabble_roster_download_async, error);

Fixed. And also fixed in other functions.

> + iface->download_async = gabble_roster_download_async;
> /* we use the default _finish functions, which assume a GSimpleAsyncResult */
> +
> + iface->get_download_at_connection =
> + gabble_roster_get_download_at_connection;
> 
> Put both assignments before the comment.

But get_download_at_connection does not use GSimpleAsync.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.