[Bug 44331] Gabble plugin API symbols should be factored out to a separate library

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=44331

--- Comment #11 from Siraj Razick <siraj.razick at collabora.co.uk> 2012-01-05 16:33:10 PST ---

> But actually, wouldn't even more idiomatic be having the plugin interface
> contain both a create_sidecar virtual function returning a GSimpleAsyncResult,
> and a create_sidecar_finish virtual function which digs out the resulting
> GabblePlugin from the GASR? Yeah this is two virtual funcs instead of one, and
> the second one is 95% the same for all plugins, but it's just a few lines
> anyway, and this way would be much cleaner IMO.
>

one detail is not clear to me about this approach, 

can we move gabble_plugin_create_sidecar_finish(...) from plugin.c to it's own
version of
xxx_plugin_create_sidecar_finish(...) per plugin ? so that
create_sidecar_cb(..) of plugin-loader.c will do something like 
plugin_iface->create_sidecar_async_finish and get a pointer in return ?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.