[Bug 44331] Gabble plugin API symbols should be factored out to a separate library

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=44331

--- Comment #17 from Olli Salli <ollisal at gmail.com> 2012-01-07 11:58:50 PST ---
(In reply to comment #16)
> First Patch with the proposed API changes + change applied to one plugin
> (test.c). if the Change is ok, I can change the other plugins as well. So r?
> please

-typedef void (*GabblePluginCreateSidecarImpl) (
+typedef GAsyncResult * (*GabblePluginCreateSidecarImpl) (

I'd additionally add "Async" to the name of the typedef to match the changed
naming of the interface member

+  if (iface->create_sidecar_finish == NULL)
+    return NULL;
+

This might come a bit out of the blue to a caller. At least log a warning here?

Additionally, it might make sense to also verify that the plugin implements
create_sidecar_finish, in gabble_plugin_create_sidecar_async (it already checks
that the plugin implements create_sidecar_async). Because a plugin can never
sensibly implement one without the other - so a create_sidecar_async operation
should fail outright, if the corresponding _finish is not implemented.

Other than these minor adjustments, looks perfect! Please carry on to porting
the other plugins. We should also cook up and attach a patch for the Ytstenut
plugin and attach it to bug 44447.

Btw, given that you're changing the Gabble plugin API, and making the
corresponding updates to a few plugins... could you briefly describe the
required changes for plugins in NEWS, for the benefit of other out of three
plugins besides Ytstenut? I know of at least one. We could make their porting
effort a breeze with this information!

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.