[Bug 43826] avoid downloading the roster at every connection

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=43826

--- Comment #3 from Jonny Lamb <jonny.lamb at collabora.co.uk> 2012-01-09 03:41:17 PST ---
+ * tp_base_contact_list_get_download_at_connection:
...
+ * The default implementation always returns %TRUE, which is correct for most
+ * protocols;

Yep, seems good. However:

+ g_return_val_if_fail (TP_IS_BASE_CONTACT_LIST (self), FALSE);

and

+ if (!TP_IS_MUTABLE_CONTACT_LIST (self))
+   return FALSE;

and

+ g_return_val_if_fail (iface != NULL, FALSE);

and

+ g_return_val_if_fail (iface->get_download_at_connection != NULL, FALSE);

I realise these are corner cases but surely these should be returning TRUE in
the error case? It might be nice time to check that all the other functions
that use tp_base_contact_list_true_func actually do the right thing?

+typedef void (*TpBaseContactListFunc) (
+ TpBaseContactList *self,
+ GAsyncReadyCallback callback,
+ gpointer user_data);

I don't like this name? It seems way too vague.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.