[Bug 44917] TpBaseChannelClass needs a get_interfaces()

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Thu Jan 19 16:16:23 CET 2012


https://bugs.freedesktop.org/show_bug.cgi?id=44917

--- Comment #4 from Jonny Lamb <jonny.lamb at collabora.co.uk> 2012-01-19 07:16:23 PST ---
Yeah this looks good, except this:

  * Subclasses should fill in #TpBaseChannelClass.channel_type,
- * #TpBaseChannelClass.target_handle_type and #TpBaseChannelClass.interfaces,
- * and implement the #TpBaseChannelClass.close virtual function.
+ * #TpBaseChannelClass.target_handle_type and
+ * #TpBaseChannelClass.get_interfaces, and implement the
+ * #TpBaseChannelClass.close virtual function.

Surely get_interfaces is also a virtual function and so this should read

    Subclasses should fill in [...], and implement the get_interfaces and close
    virtual functions.

No?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.



More information about the telepathy-bugs mailing list