[Bug 43828] avoid downloading the roster at every connection

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=43828

--- Comment #4 from Alban Crequy <alban.crequy at collabora.co.uk> 2012-01-20 09:45:28 PST ---
(In reply to comment #3)
> + { "download-at-connection",
> 
> This seems a confusing connection parameter name.
> download-contact-list-at-connection is better but is longer than the world. I
> guess we can use roster here though as it's gabble.
> "download-roster-on-connection" might be better?

Yes. Fixed.

> Hey wait, isn't the D-Bus property meant to be a connection manager parameter
> like DecloakAutomatically?

Oops. Fixed.

> + DEBUG ("don't request the roster");
> 
> Why not? Say so.

Fixed.

> Is there any way we can make gabble_roster_download_async and the changed code
> in connection_status_changed_cb share the same code perchance? Perhaps you
> could even just make connection_status_changed_cb call
> tp_base_contact_list_download_async directly?

Calling tp_base_contact_list_download_async() wouldn't work because the
subclass implementation gabble_roster_download_async() checks
gabble_roster_get_download_at_connection() and the condition is the reverse
than the one in connection_status_changed_cb().

I could create an ad-hoc function to factorize but only 3 instructions would be
factorized (the condition in the "if" is not the same).

> I get a little upset seeing new code using conn_util_send_iq_async and not the
> WockyPorter methods, but oh well, up to you if you want to fix that.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.