[Bug 44649] Gabble plugin API symbols should be factored out to a separate library

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=44649

--- Comment #22 from Siraj Razick <siraj.razick at collabora.co.uk> 2012-01-26 11:20:52 UTC ---
http://cgit.collabora.com/git/user/siraj/telepathy-gabble.git/commit/?h=windows-compile-fix&id=f36bba1f367d5439f2b60c445aa216e985d69e04

patch updated .

(In reply to comment #20)
> +Libs: -L${abs_top_srcdir}/src -lgabble-plugins
> 
> I don't think this is right for the uninstalled variant. I think it should be:
> 
>    Libs: ${abs_top_builddir}src/libgabble-plugins.la
> 
> It's fine for the installed one though.
> 
> -AM_LDFLAGS = -module -avoid-version -shared
> +AM_LDFLAGS = -avoid-version -shared -no-undefined
> 
> Why the extra space?
> 
>  libgabble_plugins_la_LIBADD = \
>      $(top_builddir)/lib/ext/telepathy-yell/telepathy-yell/libtelepathy-yell.la
> \
> +        $(top_builddir)/lib/loudmouth/libloudmouth.la \
>      $(ALL_LIBS)
> 
> Why different indentation?
> 
> -libgabble_plugins_la_SOURCES = $(top_srcdir)/gabble/plugin.h \
> - $(top_srcdir)/gabble/caps-channel-manager.h \
> - $(top_srcdir)/gabble/plugin-connection.h \
> - plugin-connection.c \
> - caps-channel-manager.c \
> - plugin.c \
> - capabilities.c \
> - debug.c \
> - sidecar.c
> +libgabble_plugins_la_SOURCES = \
> + $(top_srcdir)/gabble/capabilities.h \
> + capabilities.c \
> + $(top_srcdir)/gabble/caps-channel-manager.h \
> + caps-channel-manager.c \
> + $(top_srcdir)/gabble/debug.h \
> + debug.c \
> + $(top_srcdir)/gabble/error.h \
> + error.c \
> + $(top_srcdir)/gabble/plugin.h \
> + plugin.c \
> + $(top_srcdir)/gabble/plugin-connection.h \
> + plugin-connection.c \
> + sidecar.c
> 
> Same thing here, why different indentation? Firefox has completely ruined the
> paste though... sigh.
> 
> Other than those this patch looks fine. In future do you think you could split
> your patches into separate commits which do one thing in one commit? It makes
> it much much much easier to review and that's part of the point of having a VCS
> which makes commits so easy (unlike Subversion).

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.