[Bug 33911] Remove Loudmouth wrapper

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=33911

--- Comment #12 from Will Thompson <will.thompson at collabora.co.uk> 2012-01-28 04:58:12 PST ---
Created attachment 56254
  --> https://bugs.freedesktop.org/attachment.cgi?id=56254
disco: don't crash on replies whose <query/> is missing

This is a regression from the BYE-BYE-LOUDMOUTH branch. The logic in
request_reply_cb is meant to be:

• if the stanza is an error, pass (with 'err' having been filled in);
• else, if there is no <query/> node in the reply, set 'err' to that
  effect;
• now call the callback; it is guaranteed that if err is NULL,
  query_node is not NULL.

I inverted the check for the return value of
wocky_stanza_extract_errors(): it returns TRUE if 'reply_msg' was an
error, not FALSE.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.