[Bug 33911] Remove Loudmouth wrapper

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Mon Jan 30 21:54:00 CET 2012


https://bugs.freedesktop.org/show_bug.cgi?id=33911

--- Comment #14 from Jonny Lamb <jonny.lamb at collabora.co.uk> 2012-01-30 12:54:00 PST ---
Okay, well, I looked over this huge branch. I'm not going to claim it's the
most thorough review ever but I trust your ability to run `make check`, and
really, what's the worst that can happen. Only one question:

- else if (lm_message_get_sub_type (msg) != LM_MESSAGE_SUB_TYPE_RESULT)
+ else if (wocky_stanza_extract_errors (msg, NULL, NULL, NULL, NULL))

These two aren't really equal though, are they?

Serious hats off for doing this though; it must've been well boring.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.



More information about the telepathy-bugs mailing list