[Bug 46484] Add high-level Call bindings

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=46484

--- Comment #9 from George Kiagiadakis <kiagiadakis.george at gmail.com> 2012-03-15 04:39:50 PDT ---
(In reply to comment #7)
> (In reply to comment #4)
> > (In reply to comment #2)
> > 
> > > 
> > > +            Q_ASSERT(mPriv->remoteMembersContacts.contains(handle));
> > > 
> > > I guess we don't want to assert here
> > 
> > Why not? It's a condition that should be met at this point. Saves us from
> > accidentally  creating a null ContactPtr without noticing (when calling
> > mPriv->remoteMembersContacts[handle] below).
> 
> Sure, my point is that instead of asserting we should return an error - we
> don't want the application to crash if shit happens.

No, if you look carefully at the (complex) code of this function, you will
notice that this assertion can never be false, hence it is reasonable for it to
be an assertion. It's just there to prevent us from messing up with the code of
this function.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.