[Bug 47054] Make mission-control quit gracefully

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=47054

Alban Crequy <alban.crequy at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|http://cgit.collabora.com/g |http://cgit.collabora.com/g
                   |it/user/alban/telepathy-mis |it/user/alban/telepathy-mis
                   |sion-control.git/log/?h=exi |sion-control.git/log/?h=exi
                   |t3                          |t5

--- Comment #6 from Alban Crequy <alban.crequy at collabora.co.uk> 2012-03-26 06:00:36 PDT ---
Fixed in branch "exit5":

(In reply to comment #5)
> > +#include <fcntl.h>
> > +#include <sys/types.h>
> > +#include <sys/socket.h>
> > +#include <errno.h>
> > +#include <string.h>
> >  #include <glib.h>
> > +#include <signal.h>
> 
> These additions should be #ifdef G_OS_UNIX. At least fcntl.h is non-portable.

Done. And #include <glib.h> is moved before the ifdef since it defines
G_OS_UNIX. 

> > + retval = socketpair(AF_UNIX, SOCK_STREAM|SOCK_CLOEXEC, 0, quit_pipe);
> 
> Why a socket pair? All you need is a pipe - you don't need to write to the read
> end, read from the write end or use BSD Sockets API (which is what socketpair()
> gives you over pipe()).
> 
> SOCK_CLOEXEC is non-portable (Linux-only) but with a GLib 2.30 dependency, you
> can use g_unix_open_pipe (quit_pipe, FD_CLOEXEC, &error) which does The Right
> Thing on all platforms.

Done.

> Telepathy coding style (space before parenthesis), please.

Fixed.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.