[Bug 49348] New: contact-based Group API does not process removals correctly

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=49348

             Bug #: 49348
           Summary: contact-based Group API does not process removals
                    correctly
    Classification: Unclassified
           Product: Telepathy
           Version: git master
          Platform: Other
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: tp-glib
        AssignedTo: telepathy-bugs at lists.freedesktop.org
        ReportedBy: simon.mcvittie at collabora.co.uk
         QAContact: telepathy-bugs at lists.freedesktop.org


ids = tp_asv_get_boxed (details, "contact-ids",
      TP_HASH_TYPE_HANDLE_IDENTIFIER_MAP);
  if (ids == NULL)
    {
      DEBUG ("CM did not give identifiers, can't create TpContact");
      return;
    }

... but it's entirely normal for a group membership change that is just a
removal, not an addition, to not provide any contact identifiers at all.

This results in the sets of contacts not being reliably correct, which is
pretty bad if we're going to deprecate the sets of handles.

Having fixed that, I still get

ERROR:/home/smcv/src/fdo/tpglib/tests/dbus/group-mixin.c:452:in_the_desert:
assertion failed (members->len == 2): (3 == 2)

when I try to use the contacts as my only group API for the tests, so I don't
know quite what's going on here.

I think this indicates that we don't have enough test coverage for the
contact-based group API.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.