[Bug 49398] define D-Bus error names corresponding to members of Channel_Text_Send_Error

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Wed May 2 21:32:44 CEST 2012


https://bugs.freedesktop.org/show_bug.cgi?id=49398

Simon McVittie <simon.mcvittie at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |enhancement
            Summary|ChannelTextSendError is     |define D-Bus error names
                   |more specific than          |corresponding to members of
                   |ReceivedMessage::DeliveryDe |Channel_Text_Send_Error
                   |tails::dbusError in         |
                   |Telepathy Qt                |

--- Comment #1 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2012-05-02 12:32:44 PDT ---
Adjusting summary a bit.

The general principle is that whenever we emit an (enum member, string error
name) pair, the string error name is meant to be at least as specific as the
enum member.

In this case, we can't (always) do that, because, for instance, there is no
D-Bus error name that corresponds to "message too long":

20:13 < shadeslayer> It's just that  ReceivedMessage::DeliveryDetail::error is 
                     giving me ChannelTextSendErrorTooLong whereas  
                     ReceivedMessage::DeliveryDetails::dbusError gives me 
                     org.freedesktop.Telepathy.Error.InvalidArgument for the 
                     exact same error

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.



More information about the telepathy-bugs mailing list