[Bug 49384] [next] force single-include header

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Fri May 4 15:58:22 CEST 2012


https://bugs.freedesktop.org/show_bug.cgi?id=49384

--- Comment #1 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2012-05-04 06:58:22 PDT ---
I think before we do this, we should include
<telepathy-glib/telepathy-glib-dbus.h> in master, and make telepathy-glib.h
complete - so, I've done that.

I was going to make exceptions for some of the larger cli- and svc- headers,
but it turns out that using complete meta-headers, exclusively, slows down a
complete Gabble compilation by less than 6 seconds - so, life's too short.

Proposed structure:

<telepathy-glib/debug-ansi.h>
<telepathy-glib/properties-mixin.h>
<telepathy-glib/text-mixin.h>
  Are included directly, or preferably not included.
  (Rationale: they are all deprecated.)

<telepathy-glib/proxy-subclass.h>
  Is included directly. (Rationale: it's low-level.)

<telepathy-glib/telepathy-glib.h>
  Includes all non-generated headers except those above,
  plus enums and errors from the spec (which I consider to be still
  part of our stable ABI).

  In master, also includes generated code for svc-generic, svc-client,
  interfaces, gtypes, and all cli- code. In next, these will go away.
  I might introduce a #define that makes these go away from master too.

<telepathy-glib/telepathy-glib-dbus.h>
  Includes telepathy-glib.h and all generated code, including cli- and svc-.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.



More information about the telepathy-bugs mailing list