[Bug 47100] add a way to create accounts with properties, without knowing property names/namespaces

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Wed May 9 12:10:58 CEST 2012


https://bugs.freedesktop.org/show_bug.cgi?id=47100

--- Comment #19 from Guillaume Desmottes <guillaume.desmottes at collabora.co.uk> 2012-05-09 03:10:58 PDT ---
(In reply to comment #18)
> Yeah I think you're right. We can't have a default as it should be localised,
> so we could just require the display name and get empathy to have a good
> localised fallback? Okay done.

agreed.

> > Consistency is good indeed. I opened bug #49616 to consider changing this in
> > next.
> 
> Exciting.
> 
> > Did you try valgrinding the test to check for leaks?
> I hadn't actually. I just did now and found another leak in the simple account.

Did you forget to push the fix?


> (In reply to comment #17)
> > As I said in Comment 12, it would be ace to be able to get rid of
> > EmpathyAccountSettings (or at least removing most of its code). I'm not saying
> > that TpFutureAccount is the right answer to that but I think we should at least
> > considering it.
> > Should TpFutureAccount be renamed to TpAccountSettings and basically turned to
> > EmpathyAccountSettings?
> 
> Well, this kind of has a different purpose, doesn't it? If you could file a bug
> with your exact requirements listed that would be really useful.

Indeed, that's a wider scope than the original bug. I'll open a new one.

> btw I'm going to strongly veto the name TpAccountSettings for this object as it
> is now as it's completely misleading.

Agreed.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.



More information about the telepathy-bugs mailing list