[Bug 30874] GetContactAttributesByID: GetContactAttributes but from identifiers instead of handles

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=30874

--- Comment #10 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2012-05-09 04:28:45 PDT ---
Mostly looks good, some minor things:

+ g_set_error (&e, TP_ERROR, TP_ERROR_INVALID_ARGUMENT,
+ "We requested 1 id, and got an error for another id - Broken CM");

Please use (TP_DBUS_ERRORS, TP_DBUS_ERROR_INCONSISTENT) which specifically
means "your CM/service is broken", and cannot be confused with a genuine D-Bus
error.

+ g_set_error (&e, TP_ERROR, TP_ERROR_INVALID_ARGUMENT,
+ "We requested 1 id, but no contacts and no error - Broken CM");

Likewise.

+ * identifier in the IM protocol (an XMPP JIDs, SIP URIs, MSN Passports,
* AOL screen-names etc.)

Still unnecessarily plural: should be JID, URI, Passport, screen-name

(In reply to comment #9)
> > I'd prefer it if this returned the GPtrArray in the usual way, rather than
> > outputting it through an out parameter.
> 
> I do as an out param to make it optional. The user is supposed to already know
> its contacts, so it is common it won't need it. If I set it as return then user
> will have to unref it.

Hmm, I suppose so. It still seems odd, but if you frequently ignore it, OK.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.