[Bug 49371] [next] rethink what features should be set on TpAutomaticClientFactory

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=49371

--- Comment #35 from Guillaume Desmottes <guillaume.desmottes at collabora.co.uk> 2012-05-10 04:32:42 PDT ---
Comment on attachment 61343
  --> https://bugs.freedesktop.org/attachment.cgi?id=61343
tp_channel_join/leave_async: require TP_CHANNEL_FEATURE_CONTACTS to work
properly

Review of attachment 61343:
 --> (https://bugs.freedesktop.org/page.cgi?id=splinter.html&bug=49371&attachment=61343)
-----------------------------------------------------------------

::: telepathy-glib/channel.c
@@ +2011,5 @@
>  
>    result = g_simple_async_result_new (G_OBJECT (self), callback,
>        user_data, tp_channel_leave_async);
>  
> +  if (!tp_proxy_is_prepared (self, TP_CHANNEL_FEATURE_CONTACTS))

What happen if CONTACTS is prepared but channel doesn't implement Group? Looks
like we'll use Group anyway now.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.