[Bug 49371] [next] rethink what features should be set on TpAutomaticClientFactory

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Thu May 10 16:13:15 CEST 2012


https://bugs.freedesktop.org/show_bug.cgi?id=49371

--- Comment #43 from Xavier Claessens <xclaesse at gmail.com> 2012-05-10 07:13:15 PDT ---
(In reply to comment #38)
> Comment on attachment 61346 [details] [review]
> TpChannel: rename a few Group APIs:
> 
> Review of attachment 61346 [details] [review]:
> -----------------------------------------------------------------
> 
> ::: telepathy-glib/channel.c
> @@ +156,2 @@
> >   *
> > + * - the initial value of the #TpChannel:group-self-handle property will
> 
> do we still have group-self-handle?

No, fixed.

> ::: telepathy-glib/channel.h
> @@ +140,5 @@
> >  TpChannelGroupFlags tp_channel_group_get_flags (TpChannel *self);
> >  
> >  _TP_AVAILABLE_IN_0_16
> >  TpContact *tp_channel_group_get_self_contact (TpChannel *self);
> >  _TP_AVAILABLE_IN_0_16
> 
> Shouldn't we update the version macro as that's basically a new method with the
> old name?

True, reset them all to UNRELEASED

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.



More information about the telepathy-bugs mailing list