[Bug 50353] New: _tp_base_client_handle_channels does not check error for null (assertion) thus segfault if so

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Fri May 25 09:02:14 CEST 2012


https://bugs.freedesktop.org/show_bug.cgi?id=50353

             Bug #: 50353
           Summary: _tp_base_client_handle_channels does not check error
                    for null (assertion) thus segfault if so
    Classification: Unclassified
           Product: Telepathy
           Version: unspecified
          Platform: Other
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: libtelepathy
        AssignedTo: telepathy-bugs at lists.freedesktop.org
        ReportedBy: prahal at yahoo.com
         QAContact: telepathy-bugs at lists.freedesktop.org


Created attachment 62098
  --> https://bugs.freedesktop.org/attachment.cgi?id=62098
check for null error on handle channels

currently empathy_tp_chat_new assert on TP_IS_ACCOUNT (account) . It looks like
this is why I get a channel null and error null in
_tp_base_client_handle_channels. But if channel is null the debug log
derference error (and it is null here) for the message. Segfault ensue.
This patch check for error being non null. Else it tells an assertion happened
instead of error->message.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.



More information about the telepathy-bugs mailing list