[Bug 50341] Special trick to add a contact in WLM

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=50341

--- Comment #16 from Jonny Lamb <jonny.lamb at collabora.co.uk> 2012-05-29 02:50:18 PDT ---
(In reply to comment #15)
> Exactly, it's a bit tricky to do with multiple ids since ordering is important.
> I'll fix that when we agree on the idea :)

Cool.

> The problem is it needs override only in gabble, and only after we discovered
> jidlookup capability from server.
> 
> But now that I think about it, that modifies the virtual method for all
> instances, since it's like a class struct.
> 
> Ideally I should subclass TpDynamicHandleRepo in gabble and override its
> default implementation of ensure_handle_async. Problem is TpDynamicHandleRepo
> is not subclassable since TpHandleRepoIfaceClass and TpDynamicHandleRepo
> structs are internal. I'll have to make them public...

Yeah I reckon that's the best route. Subclass TpDynamicHandleRepo, and when
ensure_handle_async is called, see whether we're on live.com and if so, look it
up. It's a shame about having to make more of the handle repo structs public
but I think that's fine; you might have to add more public convenience
functions to TpDynamicHandleRepo to reuse as much as code as possible in your
gabble subclass.

I reckon in next we could just remove ensure_handle (the sync version)
completely, no?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.