[Bug 50341] Special trick to add a contact in WLM

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=50341

--- Comment #28 from Jonny Lamb <jonny.lamb at collabora.co.uk> 2012-05-30 03:50:32 PDT ---
(In reply to comment #25)
> Voilà my latest idea: I set an async normalization function on
> TpDynamicHandleRepo, which is already what it does for the sync normalization,
> so it makes sense to do like this.

Seems sensible to me.

> I don't think tp_handle_ensure() should be removed in next, since it's much
> more convenient than tp_handle_ensure_async() for ids coming from server, which
> is where ids comes from most of the times.

Okay, fair enough.

> I'm not sure it's worth having a cache tbh. The server round-trip happens only
> for ids typed by the user, so in practice it is only the "add contact" dialog,
> and the user is not going to re-type the same id that much.

I still think it's worthwhile, and pretty easy to achieve with your current
patches now, no? In the dyamic handle repo, in ensure_async, surely you can
just look up the string in the string_to_handle hash table; If it exists then
don't bother calling the normalize function?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.