[Bug 48210] Could TpBaseChannel be more flexible?

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=48210

--- Comment #8 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2012-05-31 08:34:08 PDT ---
(In reply to comment #7)
> Oh the other requirement is that when the channel RE-appears, it can have
> different Requested and Initiator{Handle,ID} values.

If Requested is becoming FALSE, that's fine: tp_base_channel_reopened() takes a
new initiator handle.

If Requested is becoming TRUE (which I suppose it could, in principle), a new
method, void reopened_by_request(self), would probably be the easiest solution?
(It would set the initiator to the global self-handle and Requested to TRUE.)

Or you could add a reopened_with_requested(self, requested, initiator) and
deprecate reopened() if you'd prefer; or I suppose you could even make
reopened() guess the new value of Requested from whether the initiator is the
(global) self-handle.

For channels with a channel-specific self-handle (XMPP MUC) I think it's
probably less horrible for UIs if the initiator is always the *global*
self-handle in channels initiated by us. I will admit that I haven't checked
whether Gabble currently makes that true, though.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.