<html>
    <head>
      <base href="https://bugs.freedesktop.org/" />
    </head>
    <body>
      <p>
        <div>
            <b><a class="bz_bug_link 
          bz_status_ASSIGNED "
   title="ASSIGNED --- - Provide GVariant-based access to TpMessage"
   href="https://bugs.freedesktop.org/show_bug.cgi?id=55096#c3">Comment # 3</a>
              on <a class="bz_bug_link 
          bz_status_ASSIGNED "
   title="ASSIGNED --- - Provide GVariant-based access to TpMessage"
   href="https://bugs.freedesktop.org/show_bug.cgi?id=55096">bug 55096</a>
              from <span class="vcard"><a class="email" href="mailto:guillaume.desmottes@collabora.co.uk" title="Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>"> <span class="fn">Guillaume Desmottes</span></a>
</span></b>
        <pre>Comment on <span class=""><a href="attachment.cgi?id=67390" name="attach_67390" title="tp_message_dup_part: add">attachment 67390</a> <a href="attachment.cgi?id=67390&action=edit" title="tp_message_dup_part: add">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=55096&attachment=67390'>[review]</a>
tp_message_dup_part: add

Review of <span class=""><a href="attachment.cgi?id=67390" name="attach_67390" title="tp_message_dup_part: add">attachment 67390</a> <a href="attachment.cgi?id=67390&action=edit" title="tp_message_dup_part: add">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=55096&attachment=67390'>[review]</a>:
-----------------------------------------------------------------

::: tests/dbus/cm-message.c
@@ +96,5 @@
<span class="quote">>        "Badger");
>  
> +  part_vardict = tp_message_dup_part (msg, 1);
> +  g_assert_cmpstr (g_variant_get_type_string (part_vardict), ==, "a{sv}");
> +  valid = g_variant_lookup (part_vardict, "content-type", "s", &s);</span >

you have to use "&s" as type if you don't want g_value_lookup() to copy the
string for you.

@@ +99,5 @@
<span class="quote">> +  g_assert_cmpstr (g_variant_get_type_string (part_vardict), ==, "a{sv}");
> +  valid = g_variant_lookup (part_vardict, "content-type", "s", &s);
> +  g_assert (valid);
> +  g_assert_cmpstr (s, ==, "text/plain");
> +  valid = g_variant_lookup (part_vardict, "content", "s", &s);</span >

same here.</pre>
        </div>
      </p>
      <hr>
      <span>You are receiving this mail because:</span>
      
      <ul>
          <li>You are the QA Contact for the bug.</li>
      </ul>
    </body>
</html>