[Telepathy-commits] [telepathy-haze/master] Don't leak a GHashTable in GetKnownAvatarTokens if not all tokens are valid.

Will Thompson will.thompson at collabora.co.uk
Fri Aug 15 03:28:59 PDT 2008


---
 src/connection-avatars.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/src/connection-avatars.c b/src/connection-avatars.c
index 0ea163d..7f94cc7 100644
--- a/src/connection-avatars.c
+++ b/src/connection-avatars.c
@@ -188,7 +188,7 @@ haze_connection_get_known_avatar_tokens (TpSvcConnectionInterfaceAvatars *self,
 {
     HazeConnection *conn = HAZE_CONNECTION (self);
     TpBaseConnection *base_conn = TP_BASE_CONNECTION (conn);
-    GHashTable *tokens = g_hash_table_new_full (NULL, NULL, NULL, g_free);
+    GHashTable *tokens;
     guint i;
     GError *err = NULL;
 
@@ -202,6 +202,8 @@ haze_connection_get_known_avatar_tokens (TpSvcConnectionInterfaceAvatars *self,
         return;
     }
 
+    tokens = g_hash_table_new_full (NULL, NULL, NULL, g_free);
+
     for (i = 0; i < contacts->len; i++)
     {
         TpHandle handle = g_array_index (contacts, TpHandle, i);
-- 
1.5.6.3




More information about the Telepathy-commits mailing list