[Telepathy-commits] [telepathy-gabble/master] GabbleRoomlistManager: don't redundantly check TargetHandle

Simon McVittie simon.mcvittie at collabora.co.uk
Wed Nov 5 03:47:02 PST 2008


TpBaseConnection already checks that the arguments are internally
consistent, so it's sufficient to check TargetHandleType.
---
 src/roomlist-manager.c |    6 ++----
 1 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/src/roomlist-manager.c b/src/roomlist-manager.c
index e16627a..2faa48a 100644
--- a/src/roomlist-manager.c
+++ b/src/roomlist-manager.c
@@ -325,10 +325,8 @@ gabble_roomlist_manager_handle_request (TpChannelManager *manager,
         TP_IFACE_CHANNEL_TYPE_ROOM_LIST))
     return FALSE;
 
-  if ((tp_asv_get_uint32 (request_properties,
-       TP_IFACE_CHANNEL ".TargetHandleType", NULL) != 0) ||
-      (tp_asv_get_uint32 (request_properties,
-      TP_IFACE_CHANNEL ".TargetHandle", NULL) != 0))
+  if (tp_asv_get_uint32 (request_properties,
+       TP_IFACE_CHANNEL ".TargetHandleType", NULL) != 0)
     {
       g_set_error (&error, TP_ERRORS, TP_ERROR_NOT_IMPLEMENTED,
           "RoomList channels can't have a target handle");
-- 
1.5.6.5




More information about the Telepathy-commits mailing list