[Telepathy-commits] [telepathy-gabble/master] gabble_olpc_view_get_buddy_activities: explain in which case we could have a buddy marked as member of an unexisting activity

[Guillaume Desmottes]

20080723153450-7fe3f-eb473f5b06933139dee0d752980c01e622e880b7.gz
---
 src/olpc-view.c |    9 ++++++++-
 1 files changed, 8 insertions(+), 1 deletions(-)

diff --git a/src/olpc-view.c b/src/olpc-view.c
index d66a785..85b56d9 100644
--- a/src/olpc-view.c
+++ b/src/olpc-view.c
@@ -742,7 +742,14 @@ gabble_olpc_view_get_buddy_activities (GabbleOlpcView *self,
           GUINT_TO_POINTER (room));
       if (activity == NULL)
         {
-          /* FIXME: When this could happen ? */
+          /* This shouldn't happen as long as:
+           *
+           * - Gadget doesn't send us <joined> stanzas about an activity
+           *   which was not previsouly announced as being part of the view.
+           *
+           * - We don't call gabble_olpc_view_add_buddies with an activity
+           *   which was not previoulsy added to the view.
+           */
           DEBUG ("Buddy %d is supposed to be in activity %d but view doesn't"
               " contain its info", buddy, room);
           continue;
-- 
1.5.6.5