[telepathy-mission-control/master] _mcd_account_online_request_completed: don't return early if no online requests

Simon McVittie simon.mcvittie at collabora.co.uk
Tue Apr 7 08:56:29 PDT 2009


Going through no-op processing is harmless, and means that we free the
error (which could otherwise be leaked - thanks, valgrind).
---
 src/mcd-account.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/src/mcd-account.c b/src/mcd-account.c
index 776a47b..f7403c4 100644
--- a/src/mcd-account.c
+++ b/src/mcd-account.c
@@ -2130,8 +2130,6 @@ _mcd_account_online_request_completed (McdAccount *account, GError *error)
     McdAccountPrivate *priv = MCD_ACCOUNT_PRIV (account);
     GList *list;
 
-    if (!priv->online_requests) return;
-
     list = priv->online_requests;
 
     while (list)
-- 
1.5.6.5




More information about the telepathy-commits mailing list