[telepathy-gabble/master] test-handles: stop exercising handle-holding by clients

Simon McVittie simon.mcvittie at collabora.co.uk
Mon Aug 17 04:48:02 PDT 2009


This is telepathy-glib functionality, not Gabble functionality, so there
should be no need for us to test it here (I've copied this test into
telepathy-glib and adapted it, instead).

This test would also cause a critical warning in a future telepathy-glib,
because the bus name we're using is not actually syntactically valid.

Reviewed-by: Dafydd Harries <dafydd.harries at collabora.co.uk>
---
 tests/test-handles.c |   18 ------------------
 1 files changed, 0 insertions(+), 18 deletions(-)

diff --git a/tests/test-handles.c b/tests/test-handles.c
index 45f9b2d..b4c260e 100644
--- a/tests/test-handles.c
+++ b/tests/test-handles.c
@@ -72,24 +72,6 @@ test_handles (guint handle_type)
   return_jid = tp_handle_inspect (tp_repo, handle);
   g_assert (!strcmp (return_jid, jid));
 
-  if (handle_type != TP_HANDLE_TYPE_LIST)
-    {
-      /* Hold the handle */
-      g_assert (tp_handle_client_hold (tp_repo, "TestSuite", handle, NULL) == TRUE);
-
-      /* Now unref it */
-      tp_handle_unref (tp_repo, handle);
-
-      /* Validate it, should be all healthy because client holds it still */
-      g_assert (tp_handle_is_valid (tp_repo, handle, NULL) == TRUE);
-
-      /* Ref it again */
-      tp_handle_ref (tp_repo, handle);
-
-      /* Client releases it */
-      g_assert (tp_handle_client_release (tp_repo, "TestSuite", handle, NULL) == TRUE);
-    }
-
   /* Now unref it */
   tp_handle_unref (tp_repo, handle);
 
-- 
1.5.6.5



More information about the telepathy-commits mailing list