[Telepathy-commits] [telepathy-gabble/master] tube_closed_cb: add comment explaining current design

Guillaume Desmottes guillaume.desmottes at collabora.co.uk
Tue Feb 3 03:26:12 PST 2009


---
 src/tubes-channel.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/src/tubes-channel.c b/src/tubes-channel.c
index d0edfd4..c6a8a21 100644
--- a/src/tubes-channel.c
+++ b/src/tubes-channel.c
@@ -454,6 +454,10 @@ tube_closed_cb (GabbleTubeIface *tube,
 
   tp_svc_channel_emit_closed (tube);
 
+  /* Ideally, this should be done in the factory directly but the private
+   * tubes factory and the muc factory are not aware of tube channels.
+   * This design is a legacy of the old tube API and we can't really change it
+   * without big refactoring. */
   if (priv->handle_type == TP_HANDLE_TYPE_CONTACT)
     {
       tp_channel_manager_emit_channel_closed_for_object (
-- 
1.5.6.5



More information about the telepathy-commits mailing list