[Telepathy-commits] [telepathy-glib/master] Remove obsolete FIXME for RequestHandles throwing NotImplemented

Will Thompson will.thompson at collabora.co.uk
Tue Feb 3 08:45:20 PST 2009


The spec allows it to, and the implementation does so.  We can't raise
InvalidArgument for too-big HandleTypes because new types might be added
in later specs, and the spec says we should raise NotImplemented for
HandleTypeNone. So there.
---
 telepathy-glib/base-connection.c |    9 ---------
 1 files changed, 0 insertions(+), 9 deletions(-)

diff --git a/telepathy-glib/base-connection.c b/telepathy-glib/base-connection.c
index ccee5eb..98adbc1 100644
--- a/telepathy-glib/base-connection.c
+++ b/telepathy-glib/base-connection.c
@@ -2387,15 +2387,6 @@ tp_base_connection_dbus_request_handles (TpSvcConnection *iface,
       goto out;
     }
 
-  /* FIXME: NotAvailable is the wrong error, since that's meant to be for
-   * transient errors which might go away later. It should raise
-   * NotImplemented if the handle type is >0 and <NUM_TP_HANDLE_TYPES but we
-   * don't have a repo for that type, but the spec doesn't currently allow us
-   * to. It should.
-   *
-   * If the handle type is 0 or >= NUM_TP_HANDLE_TYPES we should raise
-   * InvalidArgument.
-   */
   if (handle_repo == NULL)
     {
       DEBUG ("unimplemented handle type %u", handle_type);
-- 
1.5.6.5



More information about the telepathy-commits mailing list