[Telepathy-commits] [telepathy-gabble/master] Remove unnecessary presence update in test

Will Thompson will.thompson at collabora.co.uk
Wed Feb 4 06:25:10 PST 2009

This doesn't actually ensure that RequestStreams is processed. It
ensures that Gabble's read everything from its xmpp socket, but we don't
care about that. And all that we care about is that RequestStreams is
processed before Disconnect, which it is because ordering.
 .../jingle/test-wait-for-caps-incomplete.py        |    9 ---------
 1 files changed, 0 insertions(+), 9 deletions(-)

diff --git a/tests/twisted/jingle/test-wait-for-caps-incomplete.py b/tests/twisted/jingle/test-wait-for-caps-incomplete.py
index 72aedbe..1d0fa47 100644
--- a/tests/twisted/jingle/test-wait-for-caps-incomplete.py
+++ b/tests/twisted/jingle/test-wait-for-caps-incomplete.py
@@ -55,15 +55,6 @@ def test(q, bus, conn, stream):
     # Now we request streams before either <presence> or caps have arrived
     call_async(q, media_iface, 'RequestStreams', handle, [0]) # req audio stream
-    # Variant of the "make sure disco is processed" test hack, but this time
-    # we want to make sure RequestStreams is processed (and suspended) before
-    # presence arrives, to be able to test it properl.y
-    el = domish.Element(('jabber.client', 'presence'))
-    el['from'] = 'bob at example.com/Bar'
-    stream.send(el.toXml())
-    q.expect('dbus-signal', signal='PresenceUpdate')
-    # OK, now we can continue. End of hack
     # RequestStreams should now return NotAvailable

More information about the telepathy-commits mailing list