[Telepathy-commits] [telepathy-salut/master] src/tube-stream.c: Fix a leak on priv->parameters (value might leak if both set during construction and by a dbus SetProperty)

Alban Crequy alban.crequy at collabora.co.uk
Fri Feb 6 03:14:57 PST 2009


---
 src/tube-stream.c |    8 +++++++-
 1 files changed, 7 insertions(+), 1 deletions(-)

diff --git a/src/tube-stream.c b/src/tube-stream.c
index 8acbc78..2b19347 100644
--- a/src/tube-stream.c
+++ b/src/tube-stream.c
@@ -968,7 +968,11 @@ salut_tube_stream_finalize (GObject *object)
   SalutTubeStreamPrivate *priv = SALUT_TUBE_STREAM_GET_PRIVATE (self);
 
   g_free (priv->service);
-  g_hash_table_destroy (priv->parameters);
+  if (priv->parameters != NULL)
+    {
+      g_hash_table_destroy (priv->parameters);
+      priv->parameters = NULL;
+    }
 
   if (priv->address != NULL)
     {
@@ -1362,6 +1366,8 @@ tube_iface_props_setter (GObject *object,
       return FALSE;
     }
 
+  if (priv->parameters != NULL)
+    g_hash_table_destroy (priv->parameters);
   priv->parameters = g_value_dup_boxed (value);
 
   return TRUE;
-- 
1.5.6.5




More information about the telepathy-commits mailing list